Re: [PATCH] net: fix smc91x build for sh/ppc

From: Nicolas Pitre
Date: Tue Oct 12 2004 - 11:27:57 EST


On Tue, 12 Oct 2004, Paul Mundt wrote:

> The current smc91x code uses set_irq_type(). It looks like the m32r guys
> worked around this by adding a !defined(__m32r__) check, but this is equally
> bogus as set_irq_type() is an arm/arm26-specific function.
>
> Trying to get this to build on sh died in the same spot, so we just back out
> the m32r change and make it depend on CONFIG_ARM instead. Notably, the ppc
> build would have been broken by this as well, but it doesn't seem like anyone
> noticed this there yet.

I previously suggested that architectures without set_irq_type() define
it as an empty macro, but if only ARM has that function it's probably
saner to just enable it for ARM as you did.


Nicolas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/