Re: [PATCH] QStor SATA/RAID driver for 2.6.9-rc3

[Jeff Garzik]

James Bottomley wrote:
> On Tue, 2004-10-12 at 12:05, Jeff Garzik wrote:
>
> > I'll respectfully disagree with James...  I think the most prudent
> > course of action is to follow the example of SCSI common code.
> >
> > If the SCSI core is doing something wrong, we should fix that _first_,
> > not set a precedent of confusing dissociation.
> >
> > Everyone knows that Linux programmers engineer with their cut-n-paste
> > feature.
>
>
> So you'll be sending me the patches that do this?

I'm just saying you are encouraging inconsistency, which is wrong.

Mark should either
a) follow the style you request, _and_ submit patches to clean up the 
SCSI core, or

b) take the lock, just like the SCSI core is doing.

I disagree with the assertion that Mark's code should be different from 
the SCSI core.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/