Re: [PATCH] QStor SATA/RAID driver for 2.6.9-rc3

[Mark Lord]

>>
>> Right now that's not as easy as it could be, due to the specialized
>> libata struct parameters required, but I think it could be harmonized.
>
>
>I recall this but don't see it in my inbox anymore... did I adequately respond?

Well, that makes two of us that have lost the original.  :)

No response from you yet, and I don't want to waste the effort
on patches if they'll be rejected outright, thus the initial query:

The change would be as follows:  Export ata_scsi_simulate(),
and replace the first two parameters (struct ata_port, struct ata_device)
with a pointer to the 512-byte drive IDENTIFY response data.

That way, ata_scsi_simulate() becomes usable from drivers (like qstor)
that are not libata based.  The identify data parameter would, of course,
also be propogated down into all of the associated helper functions
that get invoked by ata_scsi_simulate() and pals.

At present, this will work, since those routines are only interested
in the identify data today, but I don't know about any future plans
there might be for it all.

Of course, even to use this, QStor will still have to create fake
identify blocks for each RAID device..

Cheers
--
Mark Lord
(hdparm keeper & the original "Linux IDE Guy")
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/