Re: 2.6.9-rc4-mm1 : oops when rmmod uhci_hcd [was: 2.6.9-rc3-mm2: oops...]

[Paul Fulghum]

On Fri, 2004-10-15 at 12:21, Alan Stern wrote:

> As I understand it, the description field is just a human-readable string
> that indicates what sort of device the hcd is.  It doesn't need to be
> unique.  In fact, the kerneldoc for request_irq() (without the updates)
> says that the dev_id value must be unique but says nothing about the
> devname.

In the SyncLink drivers I've always passed a devname
that is unique to each device instance, using the
form printf(devname, "%s%d", basename, instance_num).
Ethernet device instances also seem to do this.

I see that the generic serial 8250 driver uses
a constant name, as does aic7xxx.

Unique device names are useful for identifying
which device instance is on a particular interrupt
(/proc/interrupts), but other drivers beside uhci_hcd
use a constant name so I guess that is legal :-)

Either way, the generic IRQ code should deal with
duplicates without generating an oops.

-- 
Paul Fulghum
paulkf@xxxxxxxxxxxxx

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/