Re: [PATCH 0/8] replacing/fixing printk with pr_debug/pr_info inarch/i386 - intro

[Geert Uytterhoeven]

On Sun, 17 Oct 2004, Joe Perches wrote:
> On Sun, 2004-10-17 at 20:10 +0200, Geert Uytterhoeven wrote:
> > Iff you ever want to replace the above, make sure to do it like this:
> >     printk_info("Start... ");
> >     ...
> >     printkc_info("Ok!\n");
> > 
> > (with `printkc_info()' being a continuation of `printk_info()'. And do the same
> > for all other KERN_* variations. This would add real value, since the next step
> > is to make the printk{,c}_*() definitions conditionally empty for embedded
> > systems and/or systems with few memory.
> > 
> > Gr{oetje,eeting}s,
> 
> I suggest this is the incorrect usage.
> Start then Continue then End.
> I suppose one could use Continue/End with an implied start
> or simply End (ie:  printk)

Why?

The only things you need to know are
  - what is the printk() level? (so you can conditionally keep it out of the
    binary)
  - which printk() call contains the first part of the line? (so it can prepend
    the correct KERN_* definition)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/