Re: [PATCH] Fix incorrect kunmap_atomic in pktcdvd

[Peter Osterlund]

Andrew Morton <akpm@xxxxxxxx> writes:

> Peter Osterlund <petero2@xxxxxxxxx> wrote:
> >
> >  The pktcdvd driver uses kunmap_atomic() incorrectly. The function is
> >  supposed to take an address as the first parameter, but the pktcdvd
> >  driver passed a page pointer. Thanks to Douglas Gilbert and Jens Axboe
> >  for discovering this.
> 
> You're about the 7,000th person to make that mistake.  We really should
> catch it via typechecking but the code's really lame and nobody ever got
> around to rotorooting it.

Why was the interface made different from kmap()/kunmap() in the first
place? Wouldn't it have made more sense to let kunmap_atomic() take a
page pointer as the first parameter?

-- 
Peter Osterlund - petero2@xxxxxxxxx
http://w1.894.telia.com/~u89404340
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/