Small bug in e100?

[Esben Nielsen]

Hi,
 I am getting a warning - with a stack trace - from the e100
ethernet device when I do ifup eth0 when I use it on  Igno's real-time
branch. I do think, however, it is a general bug but I am not sure.
The problem is the call to enable_irq() just after request_irq() (see
below). As far as I can read from request_irq()/setup_irq()
in manage.c the irq is already being enabled in setup_irq()? If so the
enable_irq() line below ought to go.

Esben

>From drivers/net/e100.c:
...
        if((err = request_irq(nic->pdev->irq, e100_intr, SA_SHIRQ,
                nic->netdev->name, nic->netdev)))
                goto err_no_irq;
        e100_enable_irq(nic);
->      enable_irq(nic->pdev->irq);
        netif_wake_queue(nic->netdev);
...


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/