Re: [PATCH] [swsusp] print error message when swapping is disabled (fwd)

[Pavel Machek]

Hi!

> > +	if ((error = swsusp_swap_check())) {
> > +		printk(KERN_ERR "swsusp: FATAL: cannot find swap device, try "
> > +				"swapon -a!\n");
> 
> maybe it's just me, but i would really prefer to have the occasional
> long(er) line that splitting strings like that

It is not just you :-). Also it should probably not have KERN_ERR
level (it is not really error, you just asked for something that can
not be done) and word FATAL scares me.

But it is probably easier to put there some message first then fix it
up.

								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/