Re: [RFC] remove highmem_start_page

From: Dave Hansen
Date: Tue Oct 26 2004 - 19:33:49 EST


On Tue, 2004-10-26 at 17:23, Andrew Morton wrote:
> Dave Hansen <haveblue@xxxxxxxxxx> wrote:
> >
> > +static inline int page_is_highmem(struct page *page)
> > +{
> > + return PageHighMem(page);
> > +}
>
> (boggle). Why not just use PageHighMem() directly?

Because I was doing another, more complex, calculation before that and
realized about PageHighMem() later on. Would have also made it easier
to fix if someone came up with a better way when I posted the patch :)
I take it you'd rather just see it called directly.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/