Re: [PATCH] Remove some divide instructions

[Linus Torvalds]

On Wed, 27 Oct 2004, Zachary Amsden wrote:
> 
> Passes several tests (code looks sane, assembler looks sane, boots & 
> runs fine) on i386.  Apologies if I unlikely broke any other 
> architectures, but it's quite difficult to test them all.

I'd suggest _only_ changing the i386 version.

For example, your asm-generic changes looks senseless, since they only
make the macros more complex, without actually changing anything. And the
other architectures may want to do other things, since right now at least
some of them use things like fixed hardware registers etc which is not
necessarily appropriate for the non-asm case...

That way you'd also only modify the architecture that you can actually 
verify..

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/