Re: [PATCH] set membase in serial8250_request_port

[Russell King]

On Thu, Oct 28, 2004 at 01:24:55PM -0600, Alex Williamson wrote:
>   The iounmap/ioremap path in serial8250_release/request_port is
> terribly unbalanced.  The UPF_IOREMAP flag is used to determine if a
> port gets ioremap'd, but plays no part in whether it gets iounmap'd.
> It's easy to see how an MMIO serial port can be passed through
> uart_set_info and end up with an unmapped membase.  The results is a
> non-functional UART or worse.  I've tried to generate some discussion on
> the proper fix for this, but I haven't succeeded.  I propose the patch
> below as a safe compromise.  An MMIO uart w/ a mapbase, but no membase
> doesn't seem viable to me.  Thanks,

I'm going to be doing a major update to serial today, and these patches
are made rather unnecessary by that.  Thanks for pointing out the problem
anyway.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/