Re: [patch] Real-Time Preemption, -RT-2.6.10-rc1-mm3-V0.7.23

[K.R. Foley]

Ingo Molnar wrote:
> * Ingo Molnar <mingo@xxxxxxx> wrote:
>
>
> > i've done some further cleanups: made it .config configurable
> > (CONFIG_RTC_HISTOGRAM), moved the latency-histogram construction code
> > into separate functions to make it more apparent that there is no
> > impact to the normal codepaths. Patch attached.
>
>
> i've attached another update with a few more smaller details fixed:
>
>  - only print the histogram if a /dev/rtc using application indeed used 
>    it to get interrupts. This removes bogus printouts triggered by 
>    hwclock.
>
>  - skip the first RTC interrupt from the histogram - most of the
>    /dev/rtc applications do not handle the first event very well,
>    skewing the histogram.
>
> 	Ingo

Very nicely done. Also much less of a hack now the way you took all of 
the code out of the normal codepaths and made it into inlines that 
pretty much compile out if not being used.

kr
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/