Re: [patch 4/10] s390: network driver.

[Jeff Garzik]

Martin Schwidefsky wrote:
> [patch 4/10] s390: network driver.
>
> From: Thomas Spatzier <tspat@xxxxxxxxxx>
> From: Peter Tiedemann <ptiedem@xxxxxxxxxx>
>
> network driver changes:
>  - qeth: return -EINVAL if an skb is too large.
>  - qeth: don't call netif_stop_queue after cable pull. Drop the
>    packets instead.


You should be using netif_carrier_{on,off} properly, and not drop the 
packets.  When (if) link comes back, you requeue the packets to hardware 
(or hypervisor or whatever).  Your dev->stop() should stop operation and 
clean up anything left in your send/receive {rings | buffers}.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/