Re: [netfilter-core] [PATCH] no __initdata in netfilter?

[Patrick McHardy]

Andries Brouwer wrote:

> Stuff marked initdata that is referenced in non-init context.
Where ? The initial tables are replaced by ipt_register_table.

Regards
Patrick

> diff -uprN -X /linux/dontdiff a/net/ipv4/netfilter/ip_nat_rule.c b/net/ipv4/netfilter/ip_nat_rule.c
> --- a/net/ipv4/netfilter/ip_nat_rule.c	2004-10-30 21:44:11.000000000 +0200
> +++ b/net/ipv4/netfilter/ip_nat_rule.c	2004-11-13 22:40:51.000000000 +0100
> @@ -59,8 +59,8 @@ static struct
> 	struct ipt_replace repl;
> 	struct ipt_standard entries[3];
> 	struct ipt_error term;
> -} nat_initial_table __initdata
> -= { { "nat", NAT_VALID_HOOKS, 4,
> +} nat_initial_table = {
> +    { "nat", NAT_VALID_HOOKS, 4,
>       sizeof(struct ipt_standard) * 3 + sizeof(struct ipt_error),
>       { [NF_IP_PRE_ROUTING] = 0,
> 	[NF_IP_POST_ROUTING] = sizeof(struct ipt_standard),
> diff -uprN -X /linux/dontdiff a/net/ipv4/netfilter/iptable_filter.c b/net/ipv4/netfilter/iptable_filter.c
> --- a/net/ipv4/netfilter/iptable_filter.c	2004-10-30 21:44:11.000000000 +0200
> +++ b/net/ipv4/netfilter/iptable_filter.c	2004-11-13 22:40:51.000000000 +0100
> @@ -44,8 +44,8 @@ static struct
> 	struct ipt_replace repl;
> 	struct ipt_standard entries[3];
> 	struct ipt_error term;
> -} initial_table __initdata
> -= { { "filter", FILTER_VALID_HOOKS, 4,
> +} initial_table = {
> +    { "filter", FILTER_VALID_HOOKS, 4,
>       sizeof(struct ipt_standard) * 3 + sizeof(struct ipt_error),
>       { [NF_IP_LOCAL_IN] = 0,
> 	[NF_IP_FORWARD] = sizeof(struct ipt_standard),
>
>  

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/