Re: [PATCH][2.6.10-rc1-mm4][3/4] perfctr x86 driver updates

From: Rusty Russell
Date: Sun Nov 14 2004 - 20:13:03 EST


On Thu, 2004-11-11 at 10:37 +0100, Mikael Pettersson wrote:
> Part 3/4 of the perfctr interrupt fixes:
...
> } control;
> +#ifdef CONFIG_PERFCTR_INTERRUPT_SUPPORT
> + unsigned int interrupts_masked;
> +#endif
> } ____cacheline_aligned;
> static DEFINE_PER_CPU(struct per_cpu_cache, per_cpu_cache);

While you're here, does this really have to be cacheline aligned? I
wouldn't think so, since it's in the per-cpu section anyway.

Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/