Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg whenusing SELinux and SOCK_SEQPACKET

[James Morris]

On Thu, 18 Nov 2004, Ross Kendall Axe wrote:

> That seems eminently sensible. Again, I was just cut-n'-pasting from
> SOCK_STREAM. If these error codes are wrong, then SOCK_STREAM also needs
> fixing.

An issue here though is that what impact will this have on existing 
applications?

> > 
> > There is a non SELinux-related bug lurking in this code.
> 
> IMHO, there never was an SELinux bug here. SELinux merely exposed an 
> existing bug.

Looks like it, testing a fix now.

> I'm unable to reproduce that, or the bug you mention in your other 
> message. Care to send us your code?

See http://people.redhat.com/jmorris/net/seqpacket-killer-jm.tar.bz2 

> I think that af_unix.c needs a bit of cleaning up. All of the functions 
> are named as being stream vs dgram, even when the issue is connectionless 
> vs connection-oriented.

Agreed.


- James
-- 
James Morris
<jmorris@xxxxxxxxxx>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/