Re: [PATCH 2.6.10-rc2-bk1] media: Update drivers/media/video/arv.c

[Hirokazu Takata]

Hello,

Thank you for your kind comment, Randy.

From: "Randy.Dunlap" <rddunlap@xxxxxxxx>
Date: Wed, 17 Nov 2004 08:34:35 -0800
> > -MODULE_PARM(freq, "i");
> > -MODULE_PARM(vga, "i");
> > -MODULE_PARM(vga_interlace, "i");
> > +module_param(freq, int, 0644);
> > +module_param(vga, bool, 0644);
> > +module_param(vga_interlace, bool, 0644);
> 
> Do you want freq, vga, and vga_interface to be writeable _after_ the
> driver is loaded?  (i.e., dynamic)
> 

Yes.

I think it is preferable to make a parameter "freq" writable,
because system clock (or bus clock) might be changed dynamically
in order to reduce system power consumption, especially for embedded systems.

btw, I have no idea whether the other parameters are required to be writable
or not...

-- Takata
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/