Re: [1/7] Xen VMM #3: add ptep_establish_new to make va available

[Benjamin Herrenschmidt]

On Tue, 2004-11-30 at 23:05 +0000, Ian Pratt wrote:

> I'd appreciate a pointer to the patch. 

Well, I was hoping that David would reply with one :) It wasn't ported
to all archs tho, but I did ppc & ppc64, and he did x86 & sparc iirc

> It may still be of some use to distinguish between call sites
> where it is likely that mm == current->mm to avoid adding a
> futile test in all the others.

Maybe ...

 
> > Is there also a need for ptep_establish and ptep_establish_new to be 2
> > different functions ?
> 
> They allow different TLB invalidation behaviour. I guess it could
> be one function with an extra arg.

Not sure, my point is that we tend nowadays to have one abstraction per
call site, and I wonder if it's the right way to go ...

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/