Re: [PATCH] cosa.h ioctl numbers

[Arnd Bergmann]

On Dunnersdag 02 Dezember 2004 13:44, Jan Kasprzak wrote:
> 	The following patch reverts the changes in ioctl() numbers
> for COSA WAN card, makink the ioctl numbers the same as in 2.4, and thus
> preserving the binary compatibility with user-space utils.

>  /* Read the block from the device memory */
> -#define COSAIORMEM	_IOWR('C',0xf2, struct cosa_download)
> +#define COSAIORMEM	_IOWR('C',0xf2, struct cosa_download *)
>  
>  /* Write the block to the device memory (i.e. download the microcode) */
> -#define COSAIODOWNLD	_IOW('C',0xf2, struct cosa_download)
> +#define COSAIODOWNLD	_IOW('C',0xf2, struct cosa_download *)

Isn't that rather misleading? I suppose the real argument is 
'struct cosa_download', so you should have some kind of comment there, 
e.g.

#define COSAIODOWNLD _IOW('C',0xf2, long) /* actually struct cosa_download */

	Arnd <><

Attachment: pgp00000.pgp
Description: signature