Re: [PATCH] cosa.h ioctl numbers

[Andreas Schwab]

Jan Kasprzak <kas@xxxxxxxxxx> writes:

> Arnd Bergmann wrote:
> : >  /* Write the block to the device memory (i.e. download the microcode) */
> : > -#define COSAIODOWNLD	_IOW('C',0xf2, struct cosa_download)
> : > +#define COSAIODOWNLD	_IOW('C',0xf2, struct cosa_download *)
> : 
> : Isn't that rather misleading? I suppose the real argument is 
> : 'struct cosa_download', so you should have some kind of comment there, 
> : e.g.
> : 
> : #define COSAIODOWNLD _IOW('C',0xf2, long) /* actually struct cosa_download */
>
> 	Well, the third argument of ioctl(2) is of type
> struct cosa_download *.
>
> 	OK, second try with comments added.

If you want real compatibility you should use size_t, which is what 2.4 is
effectively using.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@xxxxxxx
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/