[PATCH 2/6] Update selinux_task_setscheduler

[Stephen Smalley]

This patch for 2.6.10-rc2-mm4 updates the selinux_task_setscheduler hook function to use
the standard helper for task permission checks since it is now safe to
audit from this hook (due to the upstream change to setscheduler() to
not hold the runqueue lock during the security hook call).   Please apply.

Signed-off-by:  Stephen Smalley <sds@xxxxxxxxxxxxxx>
Signed-off-by:  James Morris <jmorris@xxxxxxxxxx>

 security/selinux/hooks.c |   11 +----------
 1 files changed, 1 insertion(+), 10 deletions(-)

--- linux-2.6.10-rc2-mm4/security/selinux/hooks.c.orig	2004-12-01 13:02:07.819344632 -0500
+++ linux-2.6.10-rc2-mm4/security/selinux/hooks.c	2004-12-01 13:12:27.700108432 -0500
@@ -2710,16 +2710,7 @@ static int selinux_task_setrlimit(unsign
 
 static int selinux_task_setscheduler(struct task_struct *p, int policy, struct sched_param *lp)
 {
-	struct task_security_struct *tsec1, *tsec2;
-
-	tsec1 = current->security;
-	tsec2 = p->security;
-
-	/* No auditing from the setscheduler hook, since the runqueue lock
-	   is held and the system will deadlock if we try to log an audit
-	   message. */
-	return avc_has_perm_noaudit(tsec1->sid, tsec2->sid,
-				    SECCLASS_PROCESS, PROCESS__SETSCHED, NULL);
+	return task_has_perm(current, p, PROCESS__SETSCHED);
 }
 
 static int selinux_task_getscheduler(struct task_struct *p)

-- 
Stephen Smalley <sds@xxxxxxxxxxxxxx>
National Security Agency

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/