Re: [PATCH] cosa.h ioctl numbers

[Andreas Schwab]

Jan Kasprzak <kas@xxxxxxxxxx> writes:

> 	I do not understand. The _IOW() macro just uses sizeof(_third_argument)
> both on 2.4 and 2.6.

Yes, and 2.4 uses sizeof in the third argument, thus size_t is the most
natural replacement.

> I would rather have the 2.6 ioctl numbers the same as in 2.1-2.4.

You get that when you use size_t for the type, which also gives some hint
that the old definition was an unfortunate mistake and might prevent other
people from "fixing" it again.  Putting a pointer here just adds to the
confusion and should be avoided, IMHO.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@xxxxxxx
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/