Re: [PATCH] NX: Fix noexec kernel parameter / x86_64

[Zwane Mwaikambo]

On Sun, 5 Dec 2004, Ingo Molnar wrote:

> 
> * Zwane Mwaikambo <zwane@xxxxxxxxxxxxxxxx> wrote:
> 
> > +		if (!memcmp(from, "noexec=", 7)) {
> > +			extern void nonx_setup(char *str);
> > +	
> > +			nonx_setup(from + 7);
> > +		}
> 
> looks good, but please put the prototype into a header.

I bet Andrew is going to say the same thing... It just seems odd putting a 
prototype in a header for a function with one call site and gets freed 
after boot. Since i'll have to rediff, i'm also going to change the 
nonx_setup parameter type to const char * as suggested by someone in a 
private email.

Thanks,
	Zwane

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/