Re: [PATCH] isolcpus option broken in 2.6.10-rc2-bk2

[Ingo Molnar]

* Dimitri Sivanich <sivanich@xxxxxxx> wrote:

> The isolcpus option is broken in 2.6.10-rc2-bk2.  The domains are no longer
> being properly initialized (which results in a panic at bootup).
> 
> The following patch fixes this.
> 
> Signed-off-by: Dimitri Sivanich <sivanich@xxxxxxx>

Acked-by: Ingo Molnar <mingo@xxxxxxx>

only a minor nit:

> +	/* Initialize isolated CPU (physical) domains and groups */
> +	for_each_cpu_mask(i, cpu_isolated_map) {
> +		struct sched_domain *sd = NULL;

there's no need to initialize 'sd' to NULL here.

> +		int group;
> +
> +		sd = &per_cpu(phys_domains, i);
> +		group = cpu_to_phys_group(i);

> +	for_each_cpu_mask(i, cpu_isolated_map) {
> +		struct sched_domain *sd = NULL;

ditto.

> +		int group;
> +
> +		sd = &per_cpu(phys_domains, i);
> +		group = cpu_to_phys_group(i);
> +		*sd = SD_CPU_INIT;

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/