Re: [PATCH, RFC] protect call to set_tsk_need_resched() by the rq-lock

From: Ingo Molnar
Date: Tue Dec 07 2004 - 08:13:45 EST



* Michael Buesch <mbuesch@xxxxxxxxxx> wrote:

> The two attached patches (one against vanilla kernel and one against
> ck patchset) moves the rq-lock a few lines up in scheduler_tick() to
> also protect set_tsk_need_resched().
>
> Is that neccessary?

scheduler_tick() is a special case, 'current' is pinned and cannot go
away, nor can it get off the runqueue. So the patch is not needed.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/