Re: [PATCH][1/2] fix unchecked returns from kmalloc() (in kernel/module.c)

[Andries Brouwer]

On Tue, Dec 07, 2004 at 10:29:58PM +0100, Jens Axboe wrote:

> > diff -up linux-2.6.10-rc3-bk2-orig/kernel/module.c linux-2.6.10-rc3-bk2/kernel/module.c
> > --- linux-2.6.10-rc3-bk2-orig/kernel/module.c	2004-12-06 22:24:56.000000000 +0100
> > +++ linux-2.6.10-rc3-bk2/kernel/module.c	2004-12-07 21:17:00.000000000 +0100
> > @@ -334,6 +334,10 @@ static int percpu_modinit(void)
> >  	pcpu_num_allocated = 2;
> >  	pcpu_size = kmalloc(sizeof(pcpu_size[0]) * pcpu_num_allocated,
> >  			    GFP_KERNEL);
> > +	if (!pcpu_size) {
> > +		printk(KERN_ERR "Unable to allocate per-cpu memory for modules.");
> > +		return -ENOMEM;
> > +	}
> 
> I'd say these cases are similar to SLAB_PANIC. Since it runs at boot, if
> it fails it's likely an indication of some other problem, so dealing
> with it here is silly. Perhaps just panic() on a NULL return.
> 
> Both of these fortify cases aren't real problems, imho. They trip a
> stupid (no offense to the analyzer, but it's not human :) static
> analyzer, that's all.

Hi Jens -

I think I disagree a little. Experience shows that if the stupid static analyzer
spits out a hundred complaints, there are maybe five real problems.
If the source is not fixed in some way then the real problem cases
drown in the noise of "harmless" warnings.

Remains the question how to fix the source without causing bloat by inserting
lots of strings. Easiest is perhaps to write debug_printk() instead of printk()
so that the string is compiled away for everyone except for me when I need
debugging help to find out why my kernel does not boot.

Andries
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/