Re: [PATCH] isolcpus option broken in 2.6.10-rc2-bk2

[Ingo Molnar]

* Nick Piggin <piggin@xxxxxxxxxxxxxxx> wrote:

> Actually, this is wrong. And I was wrong to say that the fix was to
> initialize the dummy domain (because its ->flags are 0, there is no
> need for it to have anything else set up).
> 
> The isolated domains don't need to be set up because they correctly
> point to the dummy domain, which is already set up properly (zeroed).
> The oops is just a problem with sched_domain_debug.

(ah ... indeed, good catch. Dimitri's patch ended up working around the
'break' bug in sched_domain_debug() :-| At least this case shows that it
was right to keep SCHED_DOMAIN_DEBUG defined.)

> Andrew and/or Linus, please make sure Dimitri's patch gets reverted
> and the attached one applied before 2.6.10.

Acked-by: Ingo Molnar <mingo@xxxxxxx>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/