Re: [PATCH] CS461x gameport code isn't being included in build

[Adrian Bunk]

On Sat, Dec 04, 2004 at 05:18:46PM -0500, Ron Murray wrote:
>    I've found a typo in drivers/input/gameport/Makefile in kernel
> 2.6.9 which effectively prevents the CS461x gameport code from
> being included. Here's the diff:
> 
> --- linux-2.6.9/drivers/input/gameport/Makefile.orig	2004-10-18 
> 17:53:06.000000000 -0400
> +++ linux-2.6.9/drivers/input/gameport/Makefile	2004-12-04 
> 16:51:12.000000000 -0500
> @@ -5,7 +5,7 @@
>  # Each configuration option enables a list of files.
> 
>  obj-$(CONFIG_GAMEPORT)		+= gameport.o
> -obj-$(CONFIG_GAMEPORT_CS461X)	+= cs461x.o
> +obj-$(CONFIG_GAMEPORT_CS461x)	+= cs461x.o
>  obj-$(CONFIG_GAMEPORT_EMU10K1)	+= emu10k1-gp.o
>  obj-$(CONFIG_GAMEPORT_FM801)	+= fm801-gp.o
>  obj-$(CONFIG_GAMEPORT_L4)	+= lightning.o
> 
>    Note: the change is to a lower-case 'x' in
> 'CONFIG_GAMEPORT_CS461x'. It's hard to see.
> 
>    Kconfig in the same directory has
> 
> >> config GAMEPORT_CS461x
> >> 	tristate "Crystal SoundFusion gameport support"
> >> 	depends on GAMEPORT
> 
>    This patch brings the Makefile into line with the spelling in
> Kconfig.
>...

Good catch.

But by convention, the names of config variables in the kernel are all 
uppercase.

I'm therefore suggesting the patch below fixing this bug the other way.

>  .....Ron


Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

--- linux-2.6.10-rc2-mm4-full/drivers/input/gameport/Kconfig.old	2004-12-08 13:45:53.000000000 +0100
+++ linux-2.6.10-rc2-mm4-full/drivers/input/gameport/Kconfig	2004-12-08 13:46:06.000000000 +0100
@@ -84,7 +84,7 @@
 	tristate "ForteMedia FM801 gameport support"
 	depends on GAMEPORT
 
-config GAMEPORT_CS461x
+config GAMEPORT_CS461X
 	tristate "Crystal SoundFusion gameport support"
 	depends on GAMEPORT
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/