Re: How to add/drop SCSI drives from within the driver?

[Matthew Wilcox]

On Wed, Dec 08, 2004 at 08:07:55AM -0600, Matt Domsch wrote:
> > +} ld_device_address_t;
> 
> I would also suggest __attribute__((packed)) since you're sharing with
> userspace just to ensure you can never get it grown by the compiler
> (it shouldn't be, but just to be safe).

That's a bad idea, it forces the compiler to pessimise accesses to the
struct on most hardware.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/