Re: [mm patch] oprofile: backtrace operation does not initialized

[Greg Banks]

On Thu, Dec 09, 2004 at 02:55:19PM +0000, John Levon wrote:
> On Thu, Dec 09, 2004 at 11:53:53PM +0900, Akinobu Mita wrote:
> 
> > Or, It may be better to revert the return type of oprofile_arch_init()
> > from "void" to "int"  to get the result of initialization.
> 
> I've also lost track of why we don't return -ENODEV from the
> arch_init().

I didn't see a good reason for that change either.  Version 0.2
of the callgraph patch had the int return and worked fine.  Let's
go back.

Greg.
-- 
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/