Re: [PATCH] ATA over Ethernet driver for 2.6.9

[Greg KH]

On Thu, Dec 09, 2004 at 10:48:43AM -0500, Ed L Cashin wrote:
> Greg KH <greg@xxxxxxxxx> writes:
> 
> ...
> >> +	printk(KERN_INFO "aoe: aoeblk_ioctl: unknown ioctl %d\n", cmd);
> >
> > So I can flood the syslog by sending improper ioctls to the driver?
> > That's not nice...
> 
> Wouldn't root be the only user who could do that?  When would this
> happen?  

Your code is not preventing anyone from calling it.  So any user could.

Now if you are relying on the dev node from having the proper
permissions, that's ok too, but you might want to put a comment in
stating that.

If you aren't relying on the device node to have the proper permissions,
then you need to do a check on capable() here.



thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/