RE: [Compatibilty patch] sigtimedwait

[Zou, Nanhai]

But I can't put a
#ifdef __LITTLE_ENDIAN 
here, 
Because 
only MIPS does the byte swapping in little endian mode.
X86_64 and ia64 does not.

> -----Original Message-----
> From: David S. Miller [mailto:davem@xxxxxxxxxxxxx]
> Sent: Wednesday, December 08, 2004 1:35 PM
> To: Zou, Nanhai
> Cc: linux-kernel@xxxxxxxxxxxxxxx; akpm@xxxxxxxx; Luck, Tony;
ak@xxxxxxx;
> ralf@xxxxxxxxxxxxxx; paulus@xxxxxxxxxx; schwidefsky@xxxxxxxxxx;
> Davem@xxxxxxxxxxxxx
> Subject: Re: [Compatibilty patch] sigtimedwait
> 
> On Wed, 8 Dec 2004 08:48:56 +0800
> "Zou, Nanhai" <nanhai.zou@xxxxxxxxx> wrote:
> 
> > This patch also merges all 6 32 bit layer sys_rt_sigtimedwait in
IA64,
> > X86_64, PPC64, Sparc64, S390 and MIPS into 1 compat_rt_sigtimedwait.
> >
> > I have only tested it on X86_64 and IA64.
> > It looks a bit weird for
> > #ifdef  __MIPSEL__ in generic code.
> > But I don't have any better idea for this.
> 
> The sparc64 part looks fine.
> 
> Instead of __MIPSEL__ you should be checking endianness
> with the generic __BIG_ENDIAN and __LITTLE_ENDIAN
> macros.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/