Re: [PATCH 4/5] NOMMU: Make POSIX shmem work on ramfs-backed files

[Ingo Oeser]

You wrote:
> diff -uNrp linux-2.6.10-rc2-mm3-mmcleanup/fs/ramfs/Makefile
> linux-2.6.10-rc2-mm3-shmem/fs/ramfs/Makefile ---
> linux-2.6.10-rc2-mm3-mmcleanup/fs/ramfs/Makefile 2004-06-18
> 13:41:28.000000000 +0100 +++
> linux-2.6.10-rc2-mm3-shmem/fs/ramfs/Makefile 2004-11-26 15:36:07.000000000
> +0000 @@ -4,4 +4,10 @@
>
>  obj-$(CONFIG_RAMFS) += ramfs.o
>
> -ramfs-objs := inode.o
> +ifeq ($(CONFIG_MMU),y)
> +ramfs-objs := file-mmu.o
> +else
> +ramfs-objs := file-nommu.o
> +endif
> +
> +ramfs-objs += inode.o

What about this pattern instead:

file-mmu-y := file-mmu.o
file-mmu-n := file-nommu.o
file-mmu- := file-nommu.o
ramfs-objs += file-mmu-$(CONFIG_MMU)


Requires more work while writing it, but removes the ifeq, 
which should be avoided in makefiles as hell
-- 
Ingo Oeser
axxeo GmbH
Tiestestr. 16, 30171 Hannover
Tel. +49-511-4753706
Fax. +49-511-4753716

mailto:support@xxxxxxxx

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/