Re: [PATCH] oom killer (Core)

[William Lee Irwin III]

On Fri, 2004-12-10 at 08:32 -0800, William Lee Irwin III wrote:
>> It appears the net functional change here is the reentrancy prevention;
>> the choice of tasks is policy. The functional change may be accomplished
>> with the following:

On Fri, Dec 10, 2004 at 05:52:33PM +0100, Thomas Gleixner wrote:
> Your patch would call yield() with the lock held. On an UP machine you
> end up in the same code, as spin_locks are NOPs except for the preempt
> part.
> It's now obsolete by the fixes which were done by Andrea. 
> I'm wondering why he did not post the final version. Andrea ???
> Attached is the latest working and tested patch. It contains Andrea's
> fixes to the oom invocation and my modifications to the selection whom
> to kill.
> This should really go into mainline.

ARGH, preempt.


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/