Re: [PATCH] aic7xxx driver warning

[Dave Jones]

On Fri, Dec 10, 2004 at 11:15:56PM +0100, Miguel Angel Flores wrote:
 > Hi all,
 > 
 > These are two possible patches for the 2.6.10rc3. The patches correct a 
 > compiler warning when CONFIG_HIGHMEM64G is not defined.
 > 
 > Both patches works well. "Opt1" is the Alan Cox way and "Opt2" is the 
 > MaF way :-)

-       mask_39bit = 0x7FFFFFFFFFULL;
        if (sizeof(dma_addr_t) > 4
         && ahc_linux_get_memsize() > 0x80000000
         && pci_set_dma_mask(pdev, mask_39bit) == 0) {
+               mask_39bit = (dma_addr_t)0x7FFFFFFFFFULL;
                ahc->flags |= AHC_39BIT_ADDRESSING;
                ahc->platform_data->hw_dma_mask = mask_39bit;
        } else {

How can this work ? You're using mask_39bit before you set it
(See the pci_set_dma_mask call)

		Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/