Re: [PATCH] ide-iops: Use platform-dependent port I/O operations

[Maciej W. Rozycki]

Hi,

> >  Given the contents of <asm-generic/ide_iops.h> and platform-specific
> > peculiarities (like address-dependent hardware byte lane swappers), I
> 
> Could you give some specific examples? Thanks.

 Well, you could have a look at the few options at the top of
<asm-mips/io.h>, but on second thoughts, as long as port I/O string
operations either use an unswapping address space or revert any swapping
that might have been done by hardware (either for data or for addresses),
they should work as is.  Unlike with memory-mapped I/O that should be
feasible, because port I/O is specific to ISA/EISA/PCI which are always
little-endian.

 Anyway, I still think the patch should go in for consistency.

> > believe ide-iops should use __ide_* for port I/O string operations,
> > similarly to __ide_mm_* that are already used for memory-mapped I/O ones.
> > 
> >  Please consider.
> 
> This patch looks quite OK but it breaks few archs which don't include
> <asm-generic/ide_iops.h> and don't define __ide_[in,out]* macros.

 I can have a look at it -- that is as trivial as copying missing
definitions from <asm-generic/ide_iops.h>.  I'm afraid I won't even be
able to perform compilation tests, though.

  Maciej
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/