Re: [PATCH] ATA over Ethernet driver for 2.6.9 (with changes)

[Ed L Cashin]

Greg KH <greg@xxxxxxxxx> writes:

...
>> +enum {
>> +	DEVFL_UP = 1,	/* device is installed in system and ready for AoE->ATA commands */
>> +	DEVFL_TKILL = (1<<1),	/* flag for timer to know when to kill self */
>> +	DEVFL_EXT = (1<<2),	/* device accepts lba48 commands */
>> +	DEVFL_CLOSEWAIT = (1<<3), /* device is waiting for all closes to revalidate */
>> +	DEVFL_WC_UPDATE = (1<<4), /* this device needs to update write cache status */
>> +	DEVFL_WORKON = (1<<4),
>> +
>> +	BUFFL_FAIL = 1,
>> +};
>
> Any reason why BUFFL_FAIL and DEVFL_UP are the same value?  It looks
> like they can be used in the same variable right?

The struct Buf and the struct Aoedev both have a flags member.
BUFFL_* is for the flags member of the Buf, while DEVFL_* are bits for
the flags member of the struct Aoedev.

Although they both happen to be 1, they are conceptually unrelated, so
they have different names.  They should not be used in the same
variable.  BUFFL_ for the flags of a struct Buf, and DEVFL_ for the
flags of a struct Aoedev.

>
> The class_simple stuff looked sane, nice job.

Thanks!  It was pretty easy.

-- 
  Ed L Cashin <ecashin@xxxxxxxxxx>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/