Re: [PATCH 3/6] mv643xx_eth: fix hw checksum generation on transmit

[Christoph Hellwig]

> +			dev_kfree_skb_irq((struct sk_buff *)
> +                                                  pkt_info.return_info);

pkt_info.return_info already is a pointer to struct sk_buff

> +			/* CPU already calculated pseudo header checksum. */
> +			if (skb->nh.iph->protocol == IPPROTO_UDP) {
> +				pkt_info.cmd_sts |= ETH_UDP_FRAME;
> +				pkt_info.l4i_chk = skb->h.uh->check;
> +			}
> +			else if (skb->nh.iph->protocol == IPPROTO_TCP)
> +				pkt_info.l4i_chk = skb->h.th->check;
> +			else {

			} else if (skb->nh.iph->protocol == IPPROTO_TCP) {
				pkt_info.l4i_chk = skb->h.th->check;
			} else {

> +	pkt_info.buf_ptr = pci_map_single(0, skb->data, skb->len,
> +							PCI_DMA_TODEVICE);

s/0/NULL/ to avoid sparse warnings

> +	/*
> +	 * The hardware requires that each buffer that is <= 8 bytes
> +	 * in length must be aligned on an 8 byte boundary.
> +	 */
> +        if (p_pkt_info->byte_cnt <= 8 && p_pkt_info->buf_ptr & 0x7) {

please use tabs, not spaces for indentation.

>  #ifdef MV64340_CHECKSUM_OFFLOAD_TX
> -        int tx_first_desc;
> +        int tx_busy_desc = mp->tx_first_desc_q;

Again.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/