Re: [netfilter-core] [PATCH] no __initdata in netfilter?

[Rusty Russell]

On Tue, 2004-12-14 at 19:39 +0100, Andries Brouwer wrote:
> I think that argument is valid only when satisfying the static tool
> is especially cumbersome or inefficient, requires ugly code, etc.
> In most cases a trivial rewrite will suffice, and the result is cleaner
> code, easier to maintain, fewer bugs.

Exactly, and Harald just handed you that trivial rewrite.  It's clearer
than before, and shouldn't trip your static checker.

Your patch just ripped out the __initdata, making it suboptimal
*without* making the code clearer.

Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/