Re: [patch, 2.6.10-rc3] safe_hlt() & NMIs

[Avi Kivity]

Ingo Molnar wrote:

> +	if (__kernel_text_address(regs->eip) && *(char *)regs->eip == 0xf4)
>  
shouldn't that cast be (unsigned char *), otherwise the test will always 
fail?

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/