Re: [2.6 kernel] src/linux/drivers/serial: new serial driver

[Greg KH]

On Wed, Dec 15, 2004 at 07:00:45PM +0000, wendy xiong wrote:
> Hi All,
> 
> We are submiting a new serial driver for the 2.6 kernel. This device 
> driver is for the Digi Neo serial port adapter.
> 
> We made some changes based on great comments from linux community. We 
> used the Russell's serial_core interface, handled all initilization of 
> module correctly and used fs/seq_file.c interface for /proc entry.
> 
> I put the driver on our website:
> http://www-124.ibm.com/linux/patches/?patch_id=1672

As per Documentation/SubmittingPatches, patches need to have a
"Signed-off-by:" line in them.  And they should be posted inline if
possible.  If not possible, care to split it up into smaller pieces?

There seems to be a few places in the patch that have whitespace messed
up (spaces instead of tabs), and you do a number of printk() calls
without a KERN_ level.  Also, the coding style for the function comments
is pretty atrocious, care to fix that up to be sane?

And, why not use msleep() instead of rolling your own?

Your Makefile seems a bit odd, why are you doing it that way?

More comments when the patch is posted to the list, to make it easier to
respond to.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/