Re: [PATCH] fix inlining related build failures in mxser.c

[Jesper Juhl]

On Fri, 24 Dec 2004, Jan Engelhardt wrote:

> >Hi,
> >
> >An allyesconfig build of 2.6.10-rc3-bk16 revealed the following build 
> >failures (which arefixed by the patch below) :
> >
> >  CC      drivers/char/mxser.o
> >drivers/char/mxser.c: In function `mxser_ioctl':
> >drivers/char/mxser.c:415: sorry, unimplemented: inlining failed in call to 
> >'mxser_check_modem_status': function body not available
> >drivers/char/mxser.c:1407: sorry, unimplemented: called from here
> >make[2]: *** [drivers/char/mxser.o] Error 1
> >make[1]: *** [drivers/char] Error 2
> >make: *** [drivers] Error 2
> 
> Add -funit-at-a-time to the CFLAGS, and the compiler is happy.
> 
But, does unit-at-a-time work reliably for all compilers on all archs back 
to and including gcc 2.95.3 ?   Isn't is safer/simpler to just uninline 
the functions or reorder the file?

-- 
Jesper Juhl

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/