Re: [PATCH] fix inlining related build failures in mxser.c

[Jesper Juhl]

On Sat, 25 Dec 2004, Jan Engelhardt wrote:

> >>>> Add -funit-at-a-time to the CFLAGS, and the compiler is happy.
> >>>> 
> >>> But, does unit-at-a-time work reliably for all compilers on all archs back 
> >>> to and including gcc 2.95.3 ? 
> >>
> >>Unit-at-a-time is only available in GCC 3.4 and above.
> 
> No, it's already in my 3.3.0 (SUSE Linux 8.2) and continues to exist in 3.3.3 
> (9.2)
> 
> >The problem with unit-at-a-time isn't compiler availability,
> >but the fact that at least with gcc-3.4 on x86 it causes
> >significant stack usage increases, which in the kernel lead
> >to stack overflow problems. This is not a theoretical issue,
> >the overflows have been observed in normal kernels.
> >
> >So wrt inlining failures, the correct fix is to remove the
> >inlines or rearrange the code to allow inlining w/o unit-at-a-time.
> 
> Or making some pressure on gcc developers to fix the increase.
> 
But that won't do people using older gcc's to build the kernel any good.


-- 
Jesper Juhl


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/