Re: [patch] fix sparc64 cpu_idle()

[Mitchell Blank Jr]

(cc: list trimmed)

Coywolf Qi Hunt wrote:
> -	int ret = -EPERM;
> -
> -	if (current->pid != 0)
> -		goto out;
> -

Maybe just a WARN_ON(current->pid != 0) would be a good compromise... I
imagine that someone added the check for some reason but you're right that
just returning an error code (that presumably noone checks, right?) doesn't
make much sense

-Mitch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/