Re: waiting 10s before mounting root filesystem?

[Marcelo Tosatti]

On Fri, Dec 31, 2004 at 01:49:05AM -0800, Andrew Morton wrote:
> William Park <opengeometry@xxxxxxxx> wrote:
> >
> > -		printk("VFS: Cannot open root device \"%s\" or %s\n",
> >  -				root_device_name, b);
> >  -		printk("Please append a correct \"root=\" boot option\n");
> >  +		if (--tryagain) {
> >  +		    printk (KERN_WARNING "VFS: Waiting %dsec for root device...\n", tryagain);
> >  +		    ssleep (1);
> >  +		    goto retry;
> >  +		}
> >  +		printk (KERN_CRIT "VFS: Cannot open root device \"%s\" or %s\n", root_device_name, b);
> >  +		printk (KERN_CRIT "Please append a correct \"root=\" boot option\n");
> 
> Why is this patch needed?  If it is to offer the user a chance to insert
> the correct medium or to connect the correct device, 

The media may take a while to become readable (think of CDROM).

> why not rely upon the user doing that thing and then hitting reset? 

I think this is not the case (only) case the patch covers up.

Yes its ugly.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/