Re: [7/7] LEON SPARC V8 processor support for linux-2.6.10

[Alan Cox]

On Maw, 2005-01-04 at 19:04, Jiri Gaisler wrote:
> +            if (tty->flip.count >= TTY_FLIPBUF_SIZE) {
> +			tty->flip.work.func((void *)tty);
> +			if (tty->flip.count >= TTY_FLIPBUF_SIZE) {
> +				printk(KERN_WARNING "TTY_DONT_FLIP set\n");
> +				return;
> +			}

This code is broken. Please copy the fixes from the other
drivers/serial/*.c files as you've copied a bug from the reference code.
There are some other small cleanups in the base code that are worth
adding too in particular removing direct (ab)use of tty->flip. because
that will be changing some time in the future (when I finish debugging
the tty layer mess)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/