Re: [PATCH] x86_64: Notify user of MCE events (updated)

[Andreas Steinmetz]

Andi Kleen wrote:
> Zwane Mwaikambo <zwane@xxxxxxxxxxxxxxxx> writes:
>
> > +	 */
> > +	if (notify_user && console_logged) {
> > +		notify_user = 0;
> > +		clear_bit(0, &console_logged);
> > +		printk(KERN_EMERG "Machine check exception logged\n");
>
>
> Another suggestion: don't make this KERN_EMERG. Make it KERN_INFO. 
> Logged errors are usually correct, so there is no need for an 
> emergency.

Just asking:
How about KERN_NOTICE? KERN_INFO is in my opinion too easily lost in the 
syslog noise. Personally I'm logging KERN_INFO just to console, 
KERN_NOTICE however to file.
An MCE event would suit the description "normal but significant 
condition" of KERN_NOTICE as far as I can see.
--
Andreas Steinmetz                       SPAMmers use robotrap@xxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/