Re: 2.6.11-rc1-mm1

[Roman Zippel]

Hi,

On Fri, 14 Jan 2005, Karim Yaghmour wrote:

> Andi Kleen wrote:
> > When you have a timing bug and your logger starts to block randomly
> > you also won't debug anything. Fix is to make your buffers bigger.
> 
> relayfs allows you to choose which is best for you.
> 
> >From Documentation/filesystems/relayfs.txt:
> ...
> int    relay_open(channel_path, bufsize, nbufs, channel_flags,
> 		  channel_callbacks, start_reserve, end_reserve,
> 		  rchan_start_reserve, resize_min, resize_max, mode,
> 		  init_buf, init_buf_size)

You don't think that's a little overkill?
BTW it should return a pointer not an id, at every further access it needs 
to be looked up, killing the effects of any lockless mechanism.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/