Re: [PATCH 4/8 ] ltt for 2.6.10 : fs/ events

[Sam Ravnborg]

Hi Karim.

>  void __wait_on_buffer(struct buffer_head * bh)
>  {
> +	ltt_ev_file_system(LTT_EV_FILE_SYSTEM_BUF_WAIT_START, 0, 0, NULL);

Pleae use the subsystem name in both function name and constant - like:
> +	ltt_ev_fs(LTT_EV_FS_BUF_WAIT_START, 0, 0, NULL);

This is commonly practice.

Comment is relevant for:
file_system	=>	fs
network		=>	net
memory		=>	mm

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/