Re: [PATCH 0/2] Remove input_call_hotplug

[Greg KH]

On Tue, Jan 18, 2005 at 03:56:35PM +0100, Hannes Reinecke wrote:
> Hi all,
> 
> the input subsystem is using call_usermodehelper directly, which breaks 
> all sorts of assertions especially when using udev.
> And it's definitely going to fail once someone is trying to use netlink 
> messages for hotplug event delivery.
> 
> To remedy this I've implemented a new sysfs class 'input_device' which 
> is a representation of 'struct input_dev'. So each device listed in 
> '/proc/bus/input/devices' gets a class device associated with it.
> And we'll get proper hotplug events for each input_device which can be 
> handled by udev accordingly.

Hm, why another input class?  We already have /sys/class/input, which we
get hotplug events for.  We also have the individual input device
hotplug events, which is what I think we really want here, right?

Hm, in looking at the code some more, I think just adding a struct
device to the struct input_device would work.  You will have to refactor
out the fact that there is a pointer to a struct device in there (that
will just become the parent pointer to the input_dev's struct device).
If you do that, you can also drop a few of the fields in struct
input_dev.

That would solve all of the userspace issues your patch causes (hotplug
events would come out with the same type as before) and finally the
input subsystem would be part of the driver model properly :)

But yes, it will take more work than your patch, sorry.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/